Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exports.swift #227

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Fix Exports.swift #227

merged 4 commits into from
Aug 11, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 11, 2023

This officially cleans up the last repo left that still has an uncorrected Exports.swift. Cleans up the README and CI workflows too.

@gwynne gwynne added the no-release-needed Doesn't require a release label Aug 11, 2023
@gwynne gwynne requested review from 0xTim and MahdiBM August 11, 2023 09:03
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@gwynne
Copy link
Member Author

gwynne commented Aug 11, 2023

Note: Even though I've bumped the minimum Swift version requirement here, which is normally a semver-minor change, I'm leaving this PR marked no-release-required, on account of 5.6 was already effectively required by the dependency on Vapor, meaning no actual change has taken place aside from silencing the complaints of the 5.4 SwiftPM not knowing about DocC catalogs.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@e6a147f). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage        ?   68.44%           
=======================================
  Files           ?        5           
  Lines           ?      263           
  Branches        ?        0           
=======================================
  Hits            ?      180           
  Misses          ?       83           
  Partials        ?        0           

@gwynne gwynne merged commit f247fb5 into main Aug 11, 2023
12 checks passed
@gwynne gwynne deleted the fix-exports branch August 11, 2023 09:51
Package.swift Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release-needed Doesn't require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants