This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
working directory support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 93.58% 92.92% -0.67%
==========================================
Files 29 30 +1
Lines 702 721 +19
==========================================
+ Hits 657 670 +13
- Misses 45 51 +6
Continue to review full report at Codecov.
|
tanner0101
reviewed
Mar 21, 2017
Sources/Core/WorkingDirectory.swift
Outdated
| if file.contains(".build") { | ||
| directory = file.components(separatedBy: "/.build").first | ||
| } else { | ||
| directory = file.components(separatedBy: "/Sources").first |
There was a problem hiding this comment.
We should also have one for Packages. This is used in 3.1 when you do swift package edit
tanner0101
approved these changes
Mar 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always needed, people regularly ask, it's proven itself pretty consistent, time to go in core 🙌