Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path.Join with filepath.Join in tests #1623

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Replace path.Join with filepath.Join in tests #1623

merged 1 commit into from
Sep 18, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Sep 18, 2023

Because path.Join is for URL paths, and filepath.Join is for file paths.

@erikdubbelboer erikdubbelboer merged commit a5301d9 into valyala:master Sep 18, 2023
12 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the refactor-test-filepath-join branch September 18, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants