test: use T.TempDir instead of MkdirTemp (#1485)

* test: use T.TempDir instead of MkdirTemp * Fix test by adding reader.ff.Release()
valyala · Feb 10, 2023 · 8dcbc41 · 8dcbc41
1 parent c0c5f9c
commit 8dcbc41
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/fs_test.go b/fs_test.go
@@ -153,12 +153,7 @@ func TestServeFileSmallNoReadFrom(t *testing.T) {
 	t.Parallel()
 
 	teststr := "hello, world!"
-
-	tempdir, err := os.MkdirTemp("", "httpexpect")
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer os.RemoveAll(tempdir)
+	tempdir := t.TempDir()
 
 	if err := os.WriteFile(
 		path.Join(tempdir, "hello"), []byte(teststr), 0666); err != nil {
@@ -176,6 +171,7 @@ func TestServeFileSmallNoReadFrom(t *testing.T) {
 	if !ok {
 		t.Fatal("expected fsSmallFileReader")
 	}
+	defer reader.ff.Release()
 
 	buf := bytes.NewBuffer(nil)