Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx config files to SCGI & FastCGI examples #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add nginx config files to SCGI & FastCGI examples #169

wants to merge 1 commit into from

Conversation

Bob131
Copy link
Member

@Bob131 Bob131 commented Feb 19, 2016

ref #161

Presenting: The World's Smallest Pull Request

@arteymix
Copy link
Member

Is it possible to have standalone configuration with nginx?

@Bob131
Copy link
Member Author

Bob131 commented Feb 19, 2016

Sure, but nginx can only read from one config file. That include setup
is in the default nginx configuration

On Sat, Feb 20, 2016 at 1:17 AM, Guillaume Poirier-Morency
notifications@github.com wrote:

Is it possible to have standalone configuration with nginx?


Reply to this email directly or view it on GitHub.

@arteymix
Copy link
Member

SCGI does not support UNIX domain sockets yet! (working on it!)

Unlike Lighttpd, nginx require quite a configuration to be usable. Providing just the sample is sufficient.

Maybe we should try to tune all the parameters? see how we can get the best out of Valum? it has a really impressive amount of settings.

@Bob131
Copy link
Member Author

Bob131 commented Feb 21, 2016

You know what they say about preemptive optimization. I think it holds
particularly true here where any attempt to optimize will improve
performance in some instances but reduce performance in others.
Honestly, I'm not sure I agree with the inclusion of these sample
configs for nginx. It contains no information that doesn't appear on
the first page of a Google result (and it ought not to because users
will need to read the docs for themselves anyway to find a setup which
works for them) and as such just provides extra data for bit rot.

Feel free to throw some suggestions out there if you find some options
that should improve performance universally, but I don't know of any
and if I did I would be reporting that as a bug since they seem to take
the principle of sane defaults relatively seriously.

On Sun, Feb 21, 2016 at 3:25 PM, Guillaume Poirier-Morency
notifications@github.com wrote:

SCGI does not support UNIX domain sockets yet! (working on it!)

Unlike Lighttpd, nginx require quite a configuration to be usable.
Providing just the sample is sufficient.

Maybe we should try to tune all the parameters? see how we can get
the best out of Valum? it has a really impressive amount of settings.


Reply to this email directly or view it on GitHub.

@arteymix
Copy link
Member

Maybe it would be more appropriate to update the docs then? It's pretty empty: http://docs.valum-framework.org/en/latest/vsgi/server/fastcgi/#nginx

There are a couple of buffer options, I say it could be interesting to suggest size that fit implementation internals.

I managed to test nginx a bit and it works really well! I found (and fixed) a couple of errors under heavy load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants