Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize member naming and ordering #99

Merged
merged 13 commits into from
Nov 16, 2022
Merged

Standardize member naming and ordering #99

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
491c7f0
Try different interface ordering
neodaoist Nov 14, 2022
83d489d
Rename / Reorder variables
neodaoist Nov 14, 2022
1f2affe
Rename Claim to OptionLotClaim
neodaoist Nov 15, 2022
6c14a9f
Propose naming convention -- optionKey, claimNum, and tokenId/optionI…
neodaoist Nov 15, 2022
a364112
Lint
neodaoist Nov 15, 2022
2296abd
Revert changes to claim bucket indexing logic
neodaoist Nov 15, 2022
2bfe93e
Swap events and errors
neodaoist Nov 15, 2022
5ad0401
Revise interface
neodaoist Nov 16, 2022
2e48774
Get up to speed
neodaoist Nov 16, 2022
ccebe92
testFail
neodaoist Nov 16, 2022
416f6ba
Merge /master
neodaoist Nov 16, 2022
d15ad9a
Lint
neodaoist Nov 16, 2022
a37dfb2
Switch back to exerciseTimestamp
neodaoist Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ event NewOptionType(
address indexed underlyingAsset,
uint96 exerciseAmount,
uint96 underlyingAmount,
uint40 exerciseTimestamp,
uint40 earliestExerciseTimestamp,
neodaoist marked this conversation as resolved.
Show resolved Hide resolved
uint40 expiryTimestamp
);
```
Expand Down Expand Up @@ -314,7 +314,7 @@ unique hash `keccak256(abi.encode(Option memory))` where `settlementSeed` is set
```solidity
struct Option {
address underlyingAsset;
uint40 exerciseTimestamp;
uint40 earliestExerciseTimestamp;
uint40 expiryTimestamp;
address exerciseAsset;
uint96 underlyingAmount;
Expand Down
Loading