Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run deterministic deploys #211

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

neodaoist
Copy link
Contributor

Confirmed that deployed addresses are the same on Goerli, Arb Goerli, and Op Goerli.

@linear
Copy link

linear bot commented Jul 7, 2023

VAL-341 Dry run deterministic deploys

AC

  • Replace 2 salts with 1 salt
  • Dry run on Arb Goerli and Opt Goerli to make sure address is the same

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #211 (de20714) into master (d3458f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files           1        1           
  Lines         250      250           
  Branches       41       41           
=======================================
  Hits          248      248           
  Partials        2        2           

@megsdevs
Copy link
Contributor

megsdevs commented Jul 7, 2023

where is the command or script you used to run the deterministic deploy to on Goerli, Arb Goerli, and Op Goerli?

Can we add this info to the README

@neodaoist neodaoist changed the base branch from master to release/v1.0.1 July 14, 2023 21:55
@neodaoist
Copy link
Contributor Author

where is the command or script you used to run the deterministic deploy to on Goerli, Arb Goerli, and Op Goerli?

Can we add this info to the README

// forge script script/Deploy.s.sol --rpc-url=<RPC_URL> --broadcast --slow

@neodaoist neodaoist merged commit 6d14ebc into release/v1.0.1 Jul 21, 2023
3 of 4 checks passed
@neodaoist neodaoist deleted the neo/val-341-dry-run-deterministic-deploys branch July 21, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants