Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zero address check in constructor #134

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add zero address check in constructor #134

merged 4 commits into from
Dec 8, 2022

Conversation

neodaoist
Copy link
Contributor

@neodaoist neodaoist commented Dec 5, 2022 •
edited by 0xAlcibiades
Loading

This adds a zero address check on the constructor for added safety and to resolve a slither detector.

@neodaoist neodaoist marked this pull request as ready for review December 5, 2022 17:27
@0xAlcibiades 0xAlcibiades changed the base branch from master to fix/claim_id_bug December 5, 2022 17:40
@0xAlcibiades 0xAlcibiades changed the base branch from fix/claim_id_bug to master December 5, 2022 17:40
@0xAlcibiades 0xAlcibiades changed the base branch from master to audit-fixes December 8, 2022 22:07
@0xAlcibiades 0xAlcibiades merged commit cf78a08 into audit-fixes Dec 8, 2022
@0xAlcibiades 0xAlcibiades deleted the fix/zero-addr-check-in-constructor branch December 8, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flip-Liquid Flip-Liquid Flip-Liquid approved these changes

@0xAlcibiades 0xAlcibiades 0xAlcibiades approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neodaoist @Flip-Liquid @0xAlcibiades