Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underlying() fix for fungible options + test fixups / coverage + drop dead code #103

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Underlying() fix for fungible options + test fixups / coverage + drop dead code #103

merged 4 commits into from
Nov 16, 2022

Conversation

Flip-Liquid
Copy link
Contributor

  • Fix underlying() to correctly return info for fungible options
  • Remove dead / unreachable code
  • Stdize test naming for reverts
  • Increase coverage
  • Remove duplicate tests

Addresses #97

neodaoist
neodaoist approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@neodaoist neodaoist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice stuff.

  • Underscores in test names may improve readability, so I've been liking "testRevert_FUNCTIONNAME_WhenEXPECTEDREVERTCODE", but I'm good w/ your PR as-is.

  • There may be future cases where the revert test naming convention is limiting, e.g., multiple paths to hit the same error. In these cases, perhaps we should create another error? Or we could append a clarifier to the When clause. I prefer either of those approaches, vs. putting more than one path exercised in a single unit test.

Anyway, nice PR, this is good standardization.

src/OptionSettlement.sol Show resolved Hide resolved
@Flip-Liquid Flip-Liquid merged commit 47e4bcb into master Nov 16, 2022
@neodaoist neodaoist deleted the master_underlying_fix_test_stdization branch November 16, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neodaoist neodaoist neodaoist approved these changes

@0xAlcibiades 0xAlcibiades Awaiting requested review from 0xAlcibiades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flip-Liquid @neodaoist