Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TransactionFeedV2): Add tracking for newly completed cross-chain swaps #6156

Open
wants to merge 1 commit into
base: slava/feed-v2-vibrate-on-success
Choose a base branch
from

Conversation

sviderock
Copy link
Contributor

Description

9th PR for RET-1207. Implements tracking for newly completed cross-chain swaps.

Test plan

Re-used existing corresponding test for the same functionality from existing feed.

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.85%. Comparing base (b6bb048) to head (3e9cc7b).

Files with missing lines Patch % Lines
src/transactions/feed/TransactionFeedV2.tsx 90.19% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                        @@
##           slava/feed-v2-vibrate-on-success    #6156   +/-   ##
=================================================================
  Coverage                             88.84%   88.85%           
=================================================================
  Files                                   727      727           
  Lines                                 30847    30898   +51     
  Branches                               5641     5674   +33     
=================================================================
+ Hits                                  27406    27453   +47     
- Misses                                 3244     3248    +4     
  Partials                                197      197           
Files with missing lines Coverage Δ
src/transactions/feed/TransactionFeedV2.tsx 92.91% <90.19%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bb048...3e9cc7b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant