Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TransactionFeedV2): Add "No more transactions" toast #6153

Open
wants to merge 1 commit into
base: slava/feed-v2-handle-empty-feed
Choose a base branch
from

Conversation

sviderock
Copy link
Contributor

Description

7th PR for RET-1207. Add "No more transactions" toast when:

  • the first page is the only page and there's decent amount of transactions to trigger the scroll
  • next page returns an empty array

This behaviour will be changed in the follow-up PR once connected to the new blockchain-api handler.

Test plan

Adds tests to check the new toast behaviour.

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (a8fcd43) to head (204d407).

Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                         @@
##           slava/feed-v2-handle-empty-feed    #6153      +/-   ##
===================================================================
+ Coverage                            88.76%   88.77%   +0.01%     
===================================================================
  Files                                  727      727              
  Lines                                30780    30791      +11     
  Branches                              5628     5636       +8     
===================================================================
+ Hits                                 27321    27334      +13     
- Misses                                3261     3414     +153     
+ Partials                               198       43     -155     
Files with missing lines Coverage Δ
src/transactions/feed/TransactionFeedV2.tsx 90.38% <100.00%> (+0.72%) ⬆️

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fcd43...204d407. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant