Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TransactionFeedV2): Show stand by transactions when paginated data is empty #6152

Open
wants to merge 1 commit into
base: slava/cleanup-standby-transactions
Choose a base branch
from

Conversation

sviderock
Copy link
Contributor

Description

6th PR for RET-1207. Adds handling of the empty transaction feed. There is a possibility that a new user can have a few pending/failed transactions that are stored in standByTransactions but paginated data returning empty array for the first page. In this case we need to show stand by transactions.

Test plan

Adds test to show stand by transactions if the paginated data is empty.

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (9a5e4f3) to head (a8fcd43).

Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                           @@
##           slava/cleanup-standby-transactions    #6152      +/-   ##
======================================================================
- Coverage                               88.76%   88.76%   -0.01%     
======================================================================
  Files                                     727      727              
  Lines                                   30776    30780       +4     
  Branches                                 5630     5628       -2     
======================================================================
+ Hits                                    27319    27321       +2     
+ Misses                                   3414     3261     -153     
- Partials                                   43      198     +155     
Files with missing lines Coverage Δ
src/transactions/feed/TransactionFeedV2.tsx 89.65% <100.00%> (+0.29%) ⬆️

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5e4f3...a8fcd43. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant