chore(TransactionFeedV2): Cleanup stand by transactions in Transaction Feed V2 #6146
+101
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6146 +/- ##
========================================
Coverage 88.75% 88.76%
========================================
Files 727 727
Lines 30752 30776 +24
Branches 5624 5630 +6
========================================
+ Hits 27295 27319 +24
- Misses 3259 3414 +155
+ Partials 198 43 -155
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Comment on lines
290
to
307
| function cleanupStandByTransactions() { | ||
| const confirmedPaginationTransactions = | ||
| data?.transactions | ||
| ?.filter((tx) => tx.status !== TransactionStatus.Pending) | ||
| .map((tx) => tx.transactionHash) || [] | ||
|
|
||
| const standByTransactionsToRemove: string[] = [] | ||
| for (const tx of standByTransactions.confirmed) { | ||
| if (confirmedPaginationTransactions.includes(tx.transactionHash)) { | ||
| standByTransactionsToRemove.push(tx.transactionHash) | ||
| } | ||
| } | ||
|
|
||
| if (standByTransactionsToRemove.length) { | ||
| dispatch(removeStandByTransactions(standByTransactionsToRemove)) | ||
| } | ||
| }, | ||
| [data?.transactions, standByTransactions] |
There was a problem hiding this comment.
Would it be possible to move this logic to the reducer?
Acting on the successful fetched transactions action.
This way we follow more closely Redux best practices:
|
@jeanregisser updated |
sviderock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
4th PR of RET-1207. This implements the cleanup of confirmed stand by transactions that are already present in the feed. Currently, we keep confirmed transactions in
standByTransactionseven if they are present in the pagination data. This is unnecessary as it takes extra space from the persisted storage.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: