Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update points disclaimer copy #5822

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

kathaypacific
Copy link
Collaborator

Description

Designs here.

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (c225924) to head (9bc4f48).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5822      +/-   ##
==========================================
- Coverage   87.28%   87.28%   -0.01%     
==========================================
  Files         737      737              
  Lines       31183    31183              
  Branches     5510     5510              
==========================================
- Hits        27218    27217       -1     
- Misses       3740     3921     +181     
+ Partials      225       45     -180     
Files Coverage Δ
src/points/PointsHome.tsx 97.36% <ø> (ø)

... and 74 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c225924...9bc4f48. Read the comment docs.

@kathaypacific kathaypacific added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit dcbd86e Aug 22, 2024
16 checks passed
@kathaypacific kathaypacific deleted the kathy/points-disclaimer-copy branch August 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants