Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(send): update button text from send to continue on recipient selection #4732

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Jan 10, 2024

Description

Per Laura's request. Updated this button on selecting a recipient with address to Continue instead of Send. Also, made specific translation keys so this can be updated OTA

Test plan

Unit tests, manual

Related issues

N/A

Backwards compatibility

Yes

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a66214) 85.12% compared to head (c8218ba) 85.12%.
Report is 1 commits behind head on main.

❗ Current head c8218ba differs from pull request most recent head 31ac4b9. Consider uploading reports for the commit 31ac4b9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4732   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         726      726           
  Lines       29010    29011    +1     
  Branches     5051     5052    +1     
=======================================
+ Hits        24694    24695    +1     
  Misses       4078     4078           
  Partials      238      238           
Files Coverage Δ
src/send/SendSelectRecipient.tsx 96.10% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801d267...31ac4b9. Read the comment docs.

@satish-ravi satish-ravi enabled auto-merge (squash) January 11, 2024 00:25
@jh2oman jh2oman disabled auto-merge January 11, 2024 01:35
@jh2oman jh2oman merged commit f7b371e into main Jan 11, 2024
10 of 11 checks passed
@jh2oman jh2oman deleted the satish/select-recipient-button-text branch January 11, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants