fix(homefeed): avoid showing 'no more transactions' toast when too few transactions #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dievazqu
approved these changes
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #2783 +/- ##
=======================================
Coverage 79.74% 79.74%
=======================================
Files 600 600
Lines 21739 21741 +2
Branches 3958 3960 +2
=======================================
+ Hits 17335 17338 +3
+ Misses 4356 4355 -1
Partials 48 48
Continue to review full report at Codecov.
|
kathaypacific
added a commit
that referenced
this pull request
Aug 15, 2022
…w transactions (#2783) ### Description Annoyingly, the `onEndReached` callback is triggered on the SectionList used to render the transaction feed when navigating away from the screen on iOS, when the transaction list is too short. This causes the "no more transactions" toast to appear on the next page that is navigated to, but only once. This check for length of transactions used to exist, and I had removed it thinking it was strange #2779 (comment) - but it seems like we need it. ### Other changes N/A ### Tested Manually ### How others should test N/A ### Related issues N/A ### Backwards compatibility Yes
|
Hey @MuckT since NA is mentioned in how others should test section ,we are skipping this PR Cc: @kathaypacific |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Annoyingly, the
onEndReachedcallback is triggered on the SectionList used to render the transaction feed when navigating away from the screen on iOS, when the transaction list is too short. This causes the "no more transactions" toast to appear on the next page that is navigated to, but only once.This check for length of transactions used to exist, and I had removed it thinking it was strange #2779 (comment) - but it seems like we need it.
Other changes
N/A
Tested
Manually
How others should test
N/A
Related issues
N/A
Backwards compatibility
Yes