Skip to content

Commit

Permalink
feat: phone number keyboard suggestion on iOS (#3931)
Browse files Browse the repository at this point in the history
### Description

This is my "perennial problems" hackathon project.

On iOS, the user's phone number is now suggested, when prompted to enter
it. Tapping it above the keyboard fills the input.
This is something I wanted to do for as long as I can remember.

This one line change was made possible following the fixes made by
@kathaypacific in #3507

### Test plan

- Tested locally

<img
src="https://github.com/valora-inc/wallet/assets/57791/4357aed4-9619-4544-b753-d67df4ec520c"
width="50%" />

### Related issues

- N/A

### Backwards compatibility

Yes

Co-authored-by: Tom McGuire <Mcgtom10@gmail.com>
  • Loading branch information
jeanregisser and MuckT authored Jul 1, 2023
1 parent 43e2b5a commit e6061b1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/components/PhoneNumberInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export default function PhoneNumberInput({
value={internationalPhoneNumber}
placeholder={numberPlaceholder}
keyboardType="phone-pad"
textContentType="telephoneNumber"
testID="PhoneNumberField"
validator={ValidatorKind.Phone}
countryCallingCode={countryCallingCode}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ exports[`PhoneNumberInput renders and behaves correctly 1`] = `
]
}
testID="PhoneNumberField"
textContentType="telephoneNumber"
underlineColorAndroid="transparent"
validator="phone"
value=""
Expand Down

0 comments on commit e6061b1

Please sign in to comment.