prevent submiting of form when typeahead container is visible #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @HostListener('keydown', ['$event']) | ||
| onKeydown(e:KeyboardEvent) { | ||
| // When typeahead container is visible, prevent submitting the form | ||
| if (this.container) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
looks good! one things, please squash to one commit and rename it to: |
fkowal
force-pushed
the
fix_typeahead_submit_form
branch
from
82bf1b8 to
96ddb3c
Compare
fkowal
force-pushed
the
fix_typeahead_submit_form
branch
from
96ddb3c to
4297410
Compare
|
done |
|
cool! merging |
|
what does the beta.14 translate to ? i am basically asking about a release date |
|
just a list of issues before next ng2 release |
|
just don't want to over use https://cdnjs.com/libraries/ng2-bootstrap |
|
I'll Ping in s bit if it will raje to long |
|
ok, you can use latest ng2-bootstrap directly from master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-359