Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint warnings for nonsensical Task configurations #136

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

akx
Copy link
Member

@akx akx commented Nov 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31cac78) 92.05% compared to head (3665328) 92.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   92.05%   92.08%   +0.03%     
==========================================
  Files          65       65              
  Lines        2076     2085       +9     
  Branches      353      356       +3     
==========================================
+ Hits         1911     1920       +9     
  Misses         81       81              
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx requested review from a team, teroyks and ruksi and removed request for a team November 14, 2023 08:07
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a couple of conflicts with current master; otherwise looks good and useful!

@akx
Copy link
Member Author

akx commented Nov 14, 2023

Has a couple of conflicts with current master; otherwise looks good and useful!

Yeah, I'd evidently forgotten to assign reviewers... 😂

@akx akx force-pushed the better-task-lints branch from fe56ac4 to 83b1909 Compare November 14, 2023 08:50
@akx akx force-pushed the better-task-lints branch from 83b1909 to 3665328 Compare November 14, 2023 08:51
@akx akx requested a review from teroyks November 14, 2023 08:54
@akx akx enabled auto-merge November 14, 2023 08:54
Copy link
Contributor

@teroyks teroyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akx akx merged commit 09bff09 into master Nov 14, 2023
6 checks passed
@akx akx deleted the better-task-lints branch November 14, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants