Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot restart #210

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Spot restart #210

merged 7 commits into from
Aug 31, 2022

Conversation

drazendee
Copy link
Contributor

@drazendee drazendee commented Aug 31, 2022

Allow passing --autorestart_spot or -r when using the spot instances

Fixes #208

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to use --autorestart/--no-autorestart to have Click automatically consider the parameter a flag.

With that, the correct argument syntax should also be just --autorestart.

tests/commands/execution/test_run.py Outdated Show resolved Hide resolved
valohai_cli/commands/execution/run/frontend_command.py Outdated Show resolved Hide resolved
valohai_cli/commands/execution/run/frontend_command.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #210 (40b57a2) into master (9a91dcd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.03%     
==========================================
  Files         118      118              
  Lines        3842     3851       +9     
  Branches      635      636       +1     
==========================================
+ Hits         3302     3311       +9     
  Misses        377      377              
  Partials      163      163              
Impacted Files Coverage Δ
tests/commands/execution/test_run.py 100.00% <100.00%> (ø)
...hai_cli/commands/execution/run/frontend_command.py 92.53% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drazendee drazendee requested a review from akx August 31, 2022 12:48
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@akx akx merged commit 6e06a0f into valohai:master Aug 31, 2022
@drazendee drazendee deleted the spot-restart branch August 31, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for autorestart flag
2 participants