Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a TypeVar for ParallelRun subclasses #34

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

akx
Copy link
Member

@akx akx commented Oct 11, 2024

Should help with downstream typing for the callback.

@akx akx requested review from hylje, a team and teroyks and removed request for a team October 11, 2024 10:07
Copy link
Contributor

@hylje hylje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah makes sense, I feel the pain

@akx
Copy link
Member Author

akx commented Oct 11, 2024

Needs a newer Mypy though, heh. (#35.)

@akx akx enabled auto-merge (squash) October 11, 2024 10:15
@akx akx disabled auto-merge October 11, 2024 10:15
@akx
Copy link
Member Author

akx commented Oct 11, 2024

... no, it didn't need a newer Mypy, just needed Mypy to shush :( 🤫

@akx akx requested a review from hylje October 11, 2024 10:23
@hylje hylje merged commit d5af612 into master Oct 11, 2024
6 checks passed
@hylje hylje deleted the prun-typecl branch October 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants