Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move requirements into pyproject. #181

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

valberg
Copy link
Collaborator

@valberg valberg commented Jul 18, 2023

I'm not sure where our readthedocs configuration is - we should probably have a .readthedocs.yaml (https://docs.readthedocs.io/en/stable/config-file/index.html) ?

@valberg valberg requested a review from akx July 18, 2023 07:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #181 (c797884) into main (99841a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          15       15           
  Lines         568      568           
=======================================
  Hits          528      528           
  Misses         40       40           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valberg valberg marked this pull request as ready for review July 18, 2023 07:40
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we're just using RTD's defaults, which seems to work fine :)

@akx akx merged commit 095385d into main Jul 18, 2023
11 checks passed
@akx akx deleted the move_requirements_into_pyproject branch July 18, 2023 08:25
@akx akx mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants