Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit assert to ensure thread_shared_qb won't expand #938

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

enjoy-binbin
Copy link
Member

Although this won't happen now, adding this statement explicitly.

Although this won't happen now, adding this statement explicitly.

Signed-off-by: Binbin <binloveplay1314@qq.com>
@enjoy-binbin enjoy-binbin requested a review from madolson August 23, 2024 11:24
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (8045994) to head (0fefdc0).
Report is 5 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #938      +/-   ##
============================================
- Coverage     70.64%   70.40%   -0.24%     
============================================
  Files           112      112              
  Lines         61516    61518       +2     
============================================
- Hits          43459    43314     -145     
- Misses        18057    18204     +147     
Files Coverage Δ
src/networking.c 88.82% <100.00%> (+0.05%) ⬆️

... and 12 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit 9f4b1ad into valkey-io:unstable Aug 25, 2024
47 checks passed
@enjoy-binbin enjoy-binbin deleted the thread_shared_qb branch August 25, 2024 04:03
madolson pushed a commit that referenced this pull request Sep 2, 2024
Although this won't happen now, adding this statement explicitly.

Signed-off-by: Binbin <binloveplay1314@qq.com>
madolson pushed a commit that referenced this pull request Sep 3, 2024
Although this won't happen now, adding this statement explicitly.

Signed-off-by: Binbin <binloveplay1314@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants