Remove accurate from extra test tag #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
added
the
run-extra-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #935 +/- ##
============================================
- Coverage 70.64% 70.59% -0.05%
============================================
Files 112 112
Lines 61515 61515
============================================
- Hits 43455 43428 -27
- Misses 18060 18087 +27 |
hpatro
approved these changes
Aug 22, 2024
enjoy-binbin
approved these changes
Aug 23, 2024
madolson
added a commit
that referenced
this pull request
Sep 2, 2024
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
added a commit
that referenced
this pull request
Sep 3, 2024
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
lilpoozie2005
approved these changes
Sep 11, 2024
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Sep 14, 2024
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Ping Xie <pingxie@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if we attached the "run-extra-tests" tag it adds at least 20 minutes because the dump-fuzzer test runs with full accuracy. This fuzzer is useful, but probably only really needed for the daily, so removing it from the PRs. We still run the fuzzers, just not for as long.