Revert the default PID file back to the real default #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
|
Yes, we need keep them same. |
hwware
approved these changes
Apr 9, 2024
zuiderkwast
approved these changes
Apr 9, 2024
madolson
added a commit
that referenced
this pull request
Apr 9, 2024
The default pid file is created at /var/run/redis.pid based on the code at https://github.com/valkey-io/valkey/blob/da831c0d2242251be84a5d7f14f954c6c7fa8ee8/src/server.h#L132. Until we update it, we should reflect that in the conf file. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
The default pid file is created at /var/run/redis.pid based on the code at https://github.com/valkey-io/valkey/blob/da831c0d2242251be84a5d7f14f954c6c7fa8ee8/src/server.h#L132. Until we update it, we should reflect that in the conf file. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default pid file is created at /var/run/redis.pid based on the code at
valkey/src/server.h
Line 132 in da831c0