Skip to content

Minor change for sadd command #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

hwware
Copy link
Member

@hwware hwware commented Apr 24, 2025

Update the server.dirty only when it is necessary

Signed-off-by: hwware <wen.hui.ware@gmail.com>
@hwware hwware force-pushed the minor-change-sadd branch from 505a5a2 to 8dd15f4 Compare April 24, 2025 15:53
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (3884650) to head (8dd15f4).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2001      +/-   ##
============================================
- Coverage     71.03%   70.97%   -0.07%     
============================================
  Files           123      123              
  Lines         66037    66037              
============================================
- Hits          46911    46867      -44     
- Misses        19126    19170      +44     
Files with missing lines Coverage Δ
src/t_set.c 97.84% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hwware hwware requested a review from hpatro April 25, 2025 19:39
}
server.dirty += added;
Copy link
Collaborator

@hpatro hpatro Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the added variable is zero, it will get optimized out by the compiler I believe. I don't think we necessarily need this change for perf. For code clarity we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants