Fix macro redefinition problem in fmacros.h
#1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_DEFAULT_SOURCE` macro is defined in our code base in `"fmacros.h"`, but it might also be defined by including `<features.h>`, which is transitively included by `<sys/types.h>`. Therefore, to avoid redefinition build warnings, we check if the macro is already defined. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1704 +/- ##
============================================
+ Coverage 71.10% 71.14% +0.03%
============================================
Files 123 123
Lines 65523 65523
============================================
+ Hits 46590 46614 +24
+ Misses 18933 18909 -24 |
PingXie
approved these changes
Feb 10, 2025
madolson
approved these changes
Feb 10, 2025
zuiderkwast
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_DEFAULT_SOURCEmacro is defined in our code base in"fmacros.h", but it might also be defined by including<features.h>, which is transitively included by<sys/types.h>.Therefore, to avoid redefinition build warnings, we check if the macro is already defined.