valkey-cli: re-select previously selected database after reconnect

[xbasel]

DB0 is selecetd after reconnection regardless of the previously selected database. The prompt show the previously selected databse while working with DB0, which is misleading.
The code has been chanegd to reselect the requested database.

Fixes #1693

[xbasel]

Fixes issue #1693

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (de3672a) to head (d7b1cbc).
Report is 13 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1694      +/-   ##
============================================
- Coverage     71.04%   70.94%   -0.11%     
============================================
  Files           121      123       +2     
  Lines         65311    65535     +224     
============================================
+ Hits          46399    46492      +93     
- Misses        18912    19043     +131     

Files with missing lines	Coverage Δ
src/valkey-cli.c	54.38% <100.00%> (-1.51%)	⬇️

... and 27 files with indirect coverage changes

[enjoy-binbin]

i think we can do a re-select in here? after the reconnect

static int issueCommandRepeat(int argc, char **argv, long repeat) {
    /* In Lua debugging mode, we want to pass the "help" to the server to get
     * it's own HELP message, rather than handle it by the CLI, see ldbRepl.
     *
     * For the normal server HELP, we can process it without a connection. */
    if (!config.eval_ldb && (!strcasecmp(argv[0], "help") || !strcasecmp(argv[0], "?"))) {
        cliOutputHelp(--argc, ++argv);
        return REDIS_OK;
    }

    while (1) {
        if (config.cluster_reissue_command || context == NULL || context->err == REDIS_ERR_IO ||
            context->err == REDIS_ERR_EOF) {
            if (cliConnect(CC_FORCE) != REDIS_OK) {
                cliPrintContextError();
                config.cluster_reissue_command = 0;
                return REDIS_ERR;
            }
+           reset config
+           cliSelect();
        }

[xbasel]

i think we can do a re-select in here? after the reconnect

static int issueCommandRepeat(int argc, char **argv, long repeat) {
    /* In Lua debugging mode, we want to pass the "help" to the server to get
     * it's own HELP message, rather than handle it by the CLI, see ldbRepl.
     *
     * For the normal server HELP, we can process it without a connection. */
    if (!config.eval_ldb && (!strcasecmp(argv[0], "help") || !strcasecmp(argv[0], "?"))) {
        cliOutputHelp(--argc, ++argv);
        return REDIS_OK;
    }

    while (1) {
        if (config.cluster_reissue_command || context == NULL || context->err == REDIS_ERR_IO ||
            context->err == REDIS_ERR_EOF) {
            if (cliConnect(CC_FORCE) != REDIS_OK) {
                cliPrintContextError();
                config.cluster_reissue_command = 0;
                return REDIS_ERR;
            }
+           reset config
+           cliSelect();
        }

cliSelect() is already invoked in cliConnect():
https://github.com/valkey-io/valkey/blob/unstable/src/valkey-cli.c#L1670

[zuiderkwast]

Looks good in general.

If you write Fixes #xxxx or Closes #xxxx in the PR top comment, it links the PR to the issue closes the issue when merging. It's useful.

This PR obsoletes #1382. I prefer this new PR because it includes a test case.