Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build folder to gitignore. #1488

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

lipzhu
Copy link
Contributor

@lipzhu lipzhu commented Dec 26, 2024

Default cmake build folder in vscode is "cmake.buildDirectory": "${workspaceFolder}/build".

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
@rjd15372
Copy link
Contributor

For me it also makes sense to use the build directory for building valkey using cmake, which is the default directory for using cmake.

Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this came up at some point related to build-release. I'm OK with this.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.85%. Comparing base (9f4503c) to head (f87c424).
Report is 26 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1488      +/-   ##
============================================
- Coverage     70.86%   70.85%   -0.02%     
============================================
  Files           119      119              
  Lines         64859    64860       +1     
============================================
- Hits          45963    45954       -9     
- Misses        18896    18906      +10     

see 14 files with indirect coverage changes

@enjoy-binbin enjoy-binbin merged commit 8af35a1 into valkey-io:unstable Jan 8, 2025
49 checks passed
@lipzhu lipzhu deleted the gitignore branch January 9, 2025 07:47
kronwerk pushed a commit to kronwerk/valkey that referenced this pull request Jan 27, 2025
Default cmake build folder in vscode is `"cmake.buildDirectory": "${workspaceFolder}/build"`.

Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants