Offload replication writes to IO threads #1485
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offloads the write to replica clients to IO threads.
Main Changes
Implementation Details
In order to offload the writes,
writeToReplica
has been split into 2 parts:Additional Changes
writeToReplica
we now usewritev
in case more than 1 buffer exists.nwritten
field tossize_t
since with a replica thenwritten
can theoretically exceedint
size (not subject toNET_MAX_WRITES_PER_EVENT
limit).memchr
instead ofstrchr
:strchr
to look for the next\r
memchr
as it's more secure and resolves the issueTesting
Related issue: #761