Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover and fix new typos #1446

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Discover and fix new typos #1446

merged 2 commits into from
Dec 18, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Dec 16, 2024

  • upgrade typos
  • fix variable names

Signed-off-by: Viktor Szépe <viktor@szepe.net>
Signed-off-by: Viktor Szépe <viktor@szepe.net>
@szepeviktor szepeviktor marked this pull request as ready for review December 16, 2024 14:39
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (e024b4b) to head (c80ae03).
Report is 4 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1446      +/-   ##
============================================
- Coverage     70.82%   70.79%   -0.04%     
============================================
  Files           119      119              
  Lines         64691    64691              
============================================
- Hits          45818    45795      -23     
- Misses        18873    18896      +23     
Files with missing lines Coverage Δ
src/geohash_helper.c 99.16% <ø> (ø)
src/server.c 87.46% <100.00%> (ø)
src/server.h 100.00% <ø> (ø)
src/zmalloc.c 82.74% <ø> (ø)

... and 13 files with indirect coverage changes

Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for this.

@madolson madolson merged commit b66698b into valkey-io:unstable Dec 18, 2024
48 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute to Valkey.

@szepeviktor szepeviktor deleted the patch-1 branch December 18, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants