Do election in order based on failed primary rank to avoid voting conflicts #1018
Conversation
…flicts When multiple primary nodes fail simultaneously, the cluster can not recover within the default effective time (data_age limit). The main reason is that the vote is without ranking among multiple replica nodes, which case too many epoch conflicts. Therefore, we introduced into ranking based on the failed primary node name. Introduced a new failed_primary_rank var, this var means the rank of this myself instance in the context of all failed primary list. This var will be used in failover and we will do the failover election packets in order based on the rank, this can effectively avoid the voting conflicts. Signed-off-by: Binbin <binloveplay1314@qq.com>
| @@ -64,3 +64,34 @@ start_cluster 3 4 {tags {external:skip cluster} overrides {cluster-ping-interval | |||
| } | |||
|
|
|||
| } ;# start_cluster | |||
|
|
|||
There was a problem hiding this comment.
This test may be time-consuming. It basically cannot pass before the patch, but can pass locally after the patch.
enjoy-binbin
added
the
run-extra-tests
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1018 +/- ##
============================================
+ Coverage 70.61% 70.62% +0.01%
============================================
Files 114 114
Lines 61664 61694 +30
============================================
+ Hits 43541 43571 +30
Misses 18123 18123
|
src/cluster_legacy.c
Outdated
| continue; | ||
| } | ||
|
|
||
| if (memcmp(node->name, myself->replicaof->name, CLUSTER_NAMELEN) < 0) rank++; |
There was a problem hiding this comment.
does it make sense to sort by shard_id? replicaof is not as reliable/up-to-date as shard_id. There is the chain replication and there is still the replicaof cycle.
There was a problem hiding this comment.
Seems to make sense, I'll think about it later.
| * Specifically 0.5 second * rank. This way those failed primaries will be | ||
| * elected in rank to avoid the vote conflicts. */ | ||
| server.cluster->failover_failed_primary_rank = clusterGetFailedPrimaryRank(); | ||
| server.cluster->failover_auth_time += server.cluster->failover_failed_primary_rank * 500; |
There was a problem hiding this comment.
Curious - how did you arrive at 500? Given that CLUSTERMSG_TYPE_FAILOVER_AUTH_REQUEST is broadcast and answered pretty much right away, unless the voter is busy, I would think the network round trip time between any two nodes should be significantly less than 50 ms for all deployments. I wonder if we could tighten it up a bit to like 250 or 200?
There was a problem hiding this comment.
This 500 is just the experience points gained from here. I usually think that one election round can be completed between 500ms - 1s. Yes, i think the numbers may be adjustable, but I haven't experimented with it.
server.cluster->failover_auth_time = mstime() +
500 + /* Fixed delay of 500 milliseconds, let FAIL msg propagate. */
random() % 500; /* Random delay between 0 and 500 milliseconds. */
Signed-off-by: Binbin <binloveplay1314@qq.com>
Signed-off-by: Binbin <binloveplay1314@qq.com>
When multiple primary nodes fail simultaneously, the cluster can not recover
within the default effective time (data_age limit). The main reason is that
the vote is without ranking among multiple replica nodes, which case too many
epoch conflicts.
Therefore, we introduced into ranking based on the failed primary node name.
Introduced a new failed_primary_rank var, this var means the rank of this
myself instance in the context of all failed primary list. This var will be
used in failover and we will do the failover election packets in order based
on the rank, this can effectively avoid the voting conflicts.