Support Detailed Compilation Errors by Allowing Scripting Engine to Return robj Instead of C Strings
#1470
Assignees
Comments
|
FYI @rjd15372 |
|
@PingXie @zuiderkwast can one of you assign this issue to me? |
|
I did try assigning these issues to you but couldn't find your name in the assignee drop down list and I couldn't add new names either. Maybe Viktor would know? |
|
He needs to be a member of the org, or he needs to have commented on this issue. |
zuiderkwast
pushed a commit
that referenced
this issue
Jan 16, 2025
This commit creates a new compilation unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for running the `EVAL` command using different scripting engines. This PR has a module API change: we changed the type of error messages returned by the callback `ValkeyModuleScriptingEngineCreateFunctionsLibraryFunc` to be a `ValkeyModuleString` (aka `robj`); This PR also fixes #1470. --------- Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
proost
pushed a commit
to proost/valkey
that referenced
this issue
Jan 17, 2025
…1312) This commit creates a new compilation unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for running the `EVAL` command using different scripting engines. This PR has a module API change: we changed the type of error messages returned by the callback `ValkeyModuleScriptingEngineCreateFunctionsLibraryFunc` to be a `ValkeyModuleString` (aka `robj`); This PR also fixes valkey-io#1470. --------- Signed-off-by: Ricardo Dias <ricardo.dias@percona.com> Signed-off-by: proost <jwalag87@gmail.com>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this issue
Jan 27, 2025
…1312) This commit creates a new compilation unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for running the `EVAL` command using different scripting engines. This PR has a module API change: we changed the type of error messages returned by the callback `ValkeyModuleScriptingEngineCreateFunctionsLibraryFunc` to be a `ValkeyModuleString` (aka `robj`); This PR also fixes valkey-io#1470. --------- Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
enjoy-binbin
pushed a commit
to enjoy-binbin/valkey
that referenced
this issue
Feb 2, 2025
…1312) This commit creates a new compilation unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for running the `EVAL` command using different scripting engines. This PR has a module API change: we changed the type of error messages returned by the callback `ValkeyModuleScriptingEngineCreateFunctionsLibraryFunc` to be a `ValkeyModuleString` (aka `robj`); This PR also fixes valkey-io#1470. --------- Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Yeah if we would like to provide detailed compilation errors then we need to keep this capability but I would suggest
robjtoo over C strings.Originally posted by @PingXie in #1277 (comment)
The text was updated successfully, but these errors were encountered: