-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds isclose checks to flaky geotests #61
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 75.02% 75.06% +0.03%
==========================================
Files 132 132
Lines 34341 34378 +37
==========================================
+ Hits 25766 25805 +39
+ Misses 8575 8573 -2 ☔ View full report in Codecov by Sentry. |
Hi Jay! Thanks for the PR. |
3803b5f
to
a358a7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for fixing the linters.
Could you squash/fixup all of you commits in the first one?
Otherwise the PR looks great!
cf54a89
to
7f5302e
Compare
7f5302e
to
903fa5b
Compare
- add geochecks to conftest - uses isclose to check float values - renamed check to assert_geo_is_close - update_assert_is_geo_tests - format with black - updates from pr Signed-off-by: Jay Miller <kjaymiller@gmail.com>
a402886
to
3b2c6b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mkmkme @ahmedsobeh my approval for this PR does not work, because I touched it. We need someone else's review. |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
resolves #39