Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable uvloop tests for "run-tests" job in CI #53

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Enable uvloop tests for "run-tests" job in CI #53

merged 3 commits into from
Jul 12, 2024

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented Jul 12, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR enables uvloop tests for the 'run-tests' job, as it is for RESP3 tests. This would resolve #45.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (1901d72) to head (14b8f57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files         132      132           
  Lines       34367    34367           
=======================================
+ Hits        25780    25782    +2     
+ Misses       8587     8585    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedsobeh ahmedsobeh changed the title Enabled uvloop tests for "run-tests" job in CI Enable uvloop tests for "run-tests" job in CI Jul 12, 2024
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

.github/workflows/integration.yaml Outdated Show resolved Hide resolved
.github/workflows/integration.yaml Outdated Show resolved Hide resolved
@aiven-sal aiven-sal self-requested a review July 12, 2024 14:21
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
@ahmedsobeh ahmedsobeh merged commit 0109139 into main Jul 12, 2024
67 checks passed
@ahmedsobeh ahmedsobeh deleted the issue-45 branch July 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uvloop test "variant" not running
3 participants