-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable uvloop tests for "run-tests" job in CI #53
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 132 132
Lines 34367 34367
=======================================
+ Hits 25780 25782 +2
+ Misses 8587 8585 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
Signed-off-by: ahmedsobeh <ahmed.sobeh@aiven.io>
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR enables uvloop tests for the 'run-tests' job, as it is for RESP3 tests. This would resolve #45.