Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH: enable use of codecov secret #42

Merged
merged 1 commit into from
Jul 11, 2024
Merged

GH: enable use of codecov secret #42

merged 1 commit into from
Jul 11, 2024

Conversation

aiven-sal
Copy link
Member

Fix #21

@aiven-sal
GH: enable use of codecov secret
df696a2 
Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
@aiven-sal
Copy link
Member Author

There is no comment from codecov bot, but the upload to codecov worked. I think that the missing comment is caused by the fact that I opened a second PR for the same branch/commit. But #21 should be fixed.

ahmedsobeh
ahmedsobeh approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@ahmedsobeh ahmedsobeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedsobeh ahmedsobeh merged commit f1898b9 into main Jul 11, 2024
91 checks passed
@ahmedsobeh ahmedsobeh deleted the aiven-sal/codecov branch July 11, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedsobeh ahmedsobeh ahmedsobeh approved these changes

@mkmkme mkmkme Awaiting requested review from mkmkme mkmkme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codecov doesn't work anymore
2 participants
@aiven-sal @ahmedsobeh