Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds protocol support for redis and rediss #27

Closed
wants to merge 7 commits into from

Conversation

kjaymiller
Copy link
Contributor

@kjaymiller kjaymiller commented Jun 27, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • Adds 'redis://' and 'rediss://' to the list of accepted protocols for both sync and async connection pools
  • Updates tests to use parameterization so that tests for valkey:// and valkeys:// also test redis// and rediss://

resolves #26 #23

Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d116aa6). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   75.05%           
=======================================
  Files           ?      131           
  Lines           ?    34386           
  Branches        ?        0           
=======================================
  Hits            ?    25807           
  Misses          ?     8579           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I have a couple of requests:

  1. could you squash the lint changes in your second commit in the first one? It would make it easier for me to review commit-by-commit.
  2. ignore the CHANGES file, it wasn't really used much recently and we have a nice bot that can summarize changes in releases from PRs. It isn't perfect, but for now let's just use that (you don't have to do anything).

valkey/asyncio/connection.py Outdated Show resolved Hide resolved
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
Signed-off-by: Jay Miller <kjaymiller@gmail.com>
@kjaymiller
Copy link
Contributor Author

  1. could you squash the lint changes in your second commit in the first one? It would make it easier for me to review commit-by-commit.

I hope I did this correctly

@kjaymiller
Copy link
Contributor Author

@aiven-sal - Is there something on my end holding progress on this?

@aiven-sal
Copy link
Member

@aiven-sal - Is there something on my end holding progress on this?

Nope, there is some related work going on in #29, so I'm waiting for it to get merged. Then this will need to be rebased (I'm sorry for the inconvenience).

@aiven-sal
Copy link
Member

So #29 was merged. It should handle #23 and #25 .
This PR also contains the fix for #26.
To keep things tidier I'll close this PR, so you can open another one just for the #26 fix.
Thanks again and sorry for the delay. It was just easier to fix #23 and #25 together.

@aiven-sal aiven-sal closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing pytest.mark.skipif on TestSSLConnectionURLParsing
3 participants