-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 5.1.0b6 #20
Merged
Merged
Version 5.1.0b6 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-sal
force-pushed
the
aiven-sal/changes_for_b6
branch
2 times, most recently
from
June 14, 2024 11:35
2c6c568
to
e48049d
Compare
Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Pyright treats explicit and implicit `Any` differently, with implicit `Any` being treated as `Unknown`. Pyright raised a warning indicating an unknown member type for 'Awaitable' when used in 'ResponseT'. Using the `incr` method as an example, the warning is: ``` "warning: Type of 'incr' is partially unknown Type of 'incr' is '(name: bytes | str | memoryview, amount: int = 1) -> (Awaitable[Unknown] | Any)' (reportUnknownMemberType)" ``` By explicitly specifying 'Awaitable[Any]' in the union for 'ResponseT', this resolves the ambiguity about the member type. Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
The address_remap callback received a tuple with the host and the port. Make this clear in the typing hints. Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Run pyupgrade for 3.8. Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
When parsing the response of FT.PROFILE, handle the cases when the nested items are either not lists, or empty lists, or lists with a single item. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com> Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Make the parsing of memory stats response more robust, to not break on changes that will be added to the Redis server. Also make a test related to client kill by maxage more resilient. Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com> Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Add type hints to backoff.py Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
If the INFO response contains a single `a=b` value for any of the keys, that must also be parsed into a dictionary. Fixes #3262 Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com> Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com> Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
aiven-sal
force-pushed
the
aiven-sal/changes_for_b6
branch
from
June 14, 2024 11:36
e48049d
to
9e29e5e
Compare
mkmkme
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import some useful commits from redis-py v5.1.0b6 and bump the version