Add dynamic_startup_nodes parameter to async ValkeyCluster

[Kakadus]

Pull Request check-list

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?

Description of change

Note: I opened this PR some time ago at redis-py, but there seems to be no responses so far. It fixes a bug we currently have with redis-py, and we will migrate to valkey-py if this get accepted here : )

The async version of the ValkeyCluster lackes the dynamic_startup_nodes parameter. This PR adds the parameter to be activated when dynamic DNS endpoints for startup nodes are in use.

Enabling dynamic_startup_nodes fixes redis/redis-py#2472, which describes the problem in detail.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (e0151c1) to head (4be949a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   76.23%   76.24%           
=======================================
  Files         130      130           
  Lines       33946    33956   +10     
=======================================
+ Hits        25880    25891   +11     
+ Misses       8066     8065    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mkmkme]

Hey @Kakadus,

Thanks for your contribution! The change looks good to me. Even though it changes the default user-facing behaviour I suppose it should be fine since it shouldn't break any existing setup. I'll still wait for other maintainers to hear from them about it.

[mkmkme]

Also one request: would you be able to change your user.email git config to an actual e-mail instead of one @users.noreply.github.com?

[Kakadus]

Even though it changes the default user-facing behaviour I suppose it should be fine since it shouldn't break any existing setup. I'll still wait for other maintainers to hear from them about it.

It really shouldn't? By default, dynamic_startup_nodes is true, so the exact same code (self.set_nodes(...)) should be executed. Old code without this parameter don't see any behavior change.

• Thanks for the nice response btw

[aiven-sal]

Thank you!

[mkmkme]

Great, thank you for fixing the DCO! I have put this PR into the merge queue. This change will be a part of upcoming 6.1.0 :)