Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set socket_timeout default value to 5 seconds #120

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zioproto
Copy link
Contributor

@zioproto zioproto commented Nov 7, 2024

Fixes #119

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

Setting a default timeout value for TCP connections to avoid the process hanging forever on a TCP connection in SYN_SENT.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (49a9618) to head (02effb2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   75.17%   75.17%   -0.01%     
==========================================
  Files         132      132              
  Lines       34480    34480              
==========================================
- Hits        25922    25921       -1     
- Misses       8558     8559       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixes valkey-io#119

Signed-off-by: Saverio Proto <saverioproto@microsoft.com>
@zioproto zioproto changed the title Set socket_timeout default value to 2 seconds Set socket_timeout default value to 5 seconds Nov 7, 2024
@zioproto
Copy link
Contributor Author

zioproto commented Nov 7, 2024

@aiven-sal as discussed in #119 I have set the default value to 5 seconds

@aiven-sal aiven-sal self-assigned this Nov 7, 2024
@aiven-sal aiven-sal enabled auto-merge November 7, 2024 15:08
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a lot!

@aiven-sal aiven-sal merged commit 3f6a575 into valkey-io:main Nov 7, 2024
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process hangs due to default socket_timeout=None
3 participants