Add support for Python 3.13 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmkme
previously approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 75.29% 75.29% -0.01%
==========================================
Files 132 132
Lines 34496 34497 +1
==========================================
Hits 25974 25974
- Misses 8522 8523 +1 ☔ View full report in Codecov by Sentry. |
mkmkme
force-pushed
the
aiven-sal/support3.13
branch
from
ad17549 to
a53f2a6
Compare
|
I stand corrected, my latest change did not fix 3.13. Looking further. Quite interesting that the async version raises an exception as expected and the sync one doesn't... |
mkmkme
force-pushed
the
aiven-sal/support3.13
branch
from
1e10250 to
398d091
Compare
Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io> Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
In Python 3.13, `ssl.create_default_context()` added `VERIFY_X509_STRICT` to the flags by default which caused the tests to fail due to missing key usage. This commit adds it to the certificate configuration and replaces the certificates with reconfigured ones. Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
This commit adds support for minimum_ssl_version and maximum_ssl_version to `_ValkeyTCPServer` in tests. Previously it was written with `ssl.wrap_socket` in mind which only supported `ssl_version`. `SSLContext` OTOH supports passing both minimum and maximum supported TLS versions. This commit utilizes that. Additionally, TLS version in test_tcp_ssl_version_mismatch was fixed. It was broken since 7783e0b. This change was added there by mistake and in fact didn't change anything for Python 3.12. Instead, it seems to have hidden a bug that revealed itself with Python 3.13. Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
aiven-sal
force-pushed
the
aiven-sal/support3.13
branch
from
398d091 to
aefed4a
Compare
ahmedsobeh
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add support for Python 3.13