Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop compose format and commands v1, use supported v2+ #105

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

ArtemIsmagilov
Copy link
Contributor

@ArtemIsmagilov ArtemIsmagilov commented Sep 29, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

I propose to abandon support for compose v1. development from v2+

Signed-off-by: ArtemIsmagilov <artem.ismagilov.2000@mail.ru>
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (9b38884) to head (ba03b4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   75.19%   75.17%   -0.02%     
==========================================
  Files         132      132              
  Lines       34480    34480              
==========================================
- Hits        25927    25922       -5     
- Misses       8553     8558       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

compose.yaml Show resolved Hide resolved
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@mkmkme mkmkme merged commit 42a9c44 into valkey-io:main Sep 30, 2024
84 checks passed
@ArtemIsmagilov ArtemIsmagilov deleted the compose-supported-format branch September 30, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants