Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocole 3 (RESP3) outputs debug info with pubsub #111

Closed
jfgaudreault-p opened this issue Oct 13, 2024 · 1 comment · Fixed by #112
Closed

protocole 3 (RESP3) outputs debug info with pubsub #111

jfgaudreault-p opened this issue Oct 13, 2024 · 1 comment · Fixed by #112
Assignees

Comments

@jfgaudreault-p
Copy link

jfgaudreault-p commented Oct 13, 2024

When setting protocol=3 (RESP3), and using the pubsub features, on a message reception it seems some data is outputted in stdout by the library (or stderr not sure), here's an example of this data:
Push response: [b'subscribe', b'mychannel', 1]

This does not happen with the default protocol.

I'm using valkey-py 6.0.2

@jfgaudreault-p jfgaudreault-p changed the title protocole 3 outputs debug info with pubsub protocole 3 (RESP3) outputs debug info with pubsub Oct 13, 2024
@aiven-sal
Copy link
Member

aiven-sal commented Oct 14, 2024

Yep, it looks like the resp3 handling code has some extra "log.info" calls that are missing in the resp2 code.
They should probably be debug prints, rather then info.
As a temporary workaround you can do something like
logging.getLogger('push_response').setLevel(logging.WARNING)

@aiven-sal aiven-sal self-assigned this Oct 14, 2024
aiven-sal added a commit that referenced this issue Oct 15, 2024
Close #111

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
mkmkme pushed a commit that referenced this issue Oct 16, 2024
Close #111

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Rafiot pushed a commit to Rafiot/valkey-py that referenced this issue Dec 3, 2024
Close valkey-io#111

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Signed-off-by: Raphaël Vinot <raphael@vinot.info>
Rafiot pushed a commit to Rafiot/valkey-py that referenced this issue Dec 3, 2024
Close valkey-io#111

Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
Signed-off-by: Raphaël Vinot <raphael@vinot.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants