Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Implement Exists, Expire related commands and TTL commands #2738

Merged
merged 16 commits into from
Dec 13, 2024

Conversation

niharikabhavaraju
Copy link
Collaborator

@niharikabhavaraju niharikabhavaraju commented Nov 22, 2024

Implementing the Exists, Expire related commands - with and without options(expire, pexpire, expireat, pexpireat, expiretime, pexpiretime), TTL commands(ttl, pttl) in GO client.

@niharikabhavaraju niharikabhavaraju requested a review from a team as a code owner November 22, 2024 04:27
@niharikabhavaraju niharikabhavaraju changed the title Implemented Exists, Expire and TTL commands Go: Implement Exists, Expire related commands and TTL commands Nov 22, 2024
Copy link
Collaborator

@janhavigupta007 janhavigupta007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the tests are failing in the workflow, please run the tests to confirm and fix.

Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
niharikabhavaraju and others added 6 commits November 27, 2024 14:15
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
…rrectly by removing newlines between branch names.

Signed-off-by: ikolomi <ikolomin@amazon.com>
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
niharikabhavaraju and others added 3 commits November 27, 2024 14:17
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
niharikabhavaraju and others added 3 commits December 9, 2024 12:15
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
Signed-off-by: Niharika Bhavaraju <31915502+niharikabhavaraju@users.noreply.github.com>
niharikabhavaraju and others added 2 commits December 12, 2024 08:44
Signed-off-by: Niharika Bhavaraju <nbhavaraju@google.com>
@janhavigupta007 janhavigupta007 merged commit ab31e48 into valkey-io:main Dec 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants