Java: VSS commans init #2385
Open
Java: VSS commans init #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
temporarily deployed
to
AWS_ACTIONS
GitHub Actions
Inactive
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
acarbonetto
reviewed
Oct 3, 2024
| @@ -257,6 +257,10 @@ enum RequestType { | |||
| ScriptFlush = 216; | |||
| ScriptKill = 217; | |||
| ScriptShow = 218; | |||
|
|
|||
| FtCreate = 2000; | |||
There was a problem hiding this comment.
2??? for VSS modules work?
| @@ -165,8 +165,8 @@ jar.dependsOn('copyNativeLib') | |||
| javadoc.dependsOn('copyNativeLib') | |||
| copyNativeLib.dependsOn('buildRustRelease') | |||
| compileTestJava.dependsOn('copyNativeLib') | |||
| test.dependsOn('buildRust') | |||
| testFfi.dependsOn('buildRust') | |||
| test.dependsOn('buildRustRelease') | |||
There was a problem hiding this comment.
why? I thought we were okay with running tests vs the debug version?
There was a problem hiding this comment.
gradle still runs UT on release due to copyNativeLib. At least it doesn't build debug version which is never used.
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FT.CREATE(#422)FT.SEARCH(#423)FT.DROP(#424)