Go: Implementing List commands #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
ravisi21
approved these changes
Oct 1, 2024
eifrah-aws
reviewed
Oct 1, 2024
eifrah-aws
approved these changes
Oct 1, 2024
| // | ||
| // Return value: | ||
| // The Result[string] containing the value of the first element. | ||
| // If key does not exist, [api.CreateNilStringResult()] will be returned. |
There was a problem hiding this comment.
Suggested change
| // If key does not exist, [api.CreateNilStringResult()] will be returned. | |
| // If key does not exist, `nil` will be returned. |
For the end user it does not matter where null comes from. We should describe what returned and when.
There was a problem hiding this comment.
Here, the api.CreateNilStringResult() is returning nil object, whereas it's returning api.Result[string]{val: "", isNil: true} object. To not make it too verbose, we decided to replace it with a function and link in the docs.
Please let me know if you think otherwise. Going ahead with the merge for now, I can address any change required in the next PR.
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the following List commands: