Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Check the response type sent from rust in Go #2310

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Go: Check the response type sent from rust in Go #2310

merged 9 commits into from
Sep 26, 2024

Conversation

janhavigupta007
Copy link
Collaborator

@janhavigupta007 janhavigupta007 commented Sep 18, 2024 •
edited
Loading

  • Adding a ResponseType enum to check if the correct response is being sent from rust.
  • Also validating if command_response being sent is null.
  • Adding struct to return primitive types in order to pass the info when response received from valkey is nil.

@janhavigupta007
Go: Handling generic arrays instead of only string arrays
400aaaa 
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007
Merge remote-tracking branch 'upstream/main' into go/generic_array
1158e6d
@janhavigupta007
Resolving comments
06d3da7 
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007
Go:Adding a response_type enum to check that correct response type is…
77b822e 
… passed from rust

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007 janhavigupta007 requested a review from a team as a code owner September 18, 2024 08:13
@janhavigupta007 janhavigupta007 added the go golang wrapper label Sep 18, 2024
@janhavigupta007 janhavigupta007 self-assigned this Sep 18, 2024
@janhavigupta007 janhavigupta007 requested review from Yury-Fridlyand and eifrah-aws and removed request for Yury-Fridlyand and eifrah-aws September 18, 2024 08:25
@janhavigupta007 janhavigupta007 marked this pull request as draft September 18, 2024 09:28
@janhavigupta007
Go:Fixing tests and doc comments
2780211 
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007 janhavigupta007 marked this pull request as ready for review September 24, 2024 06:12
ravisi21
ravisi21 reviewed Sep 24, 2024
View reviewed changes
eifrah-aws
eifrah-aws requested changes Sep 24, 2024
View reviewed changes
@eifrah-aws eifrah-aws mentioned this pull request Sep 25, 2024
Merged
@janhavigupta007
Adding nested type check in map and array handlers
0e549da 
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007
Go:Adding a generic type Result in GO
5894ac0 
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
@janhavigupta007 janhavigupta007 merged commit 2c7ec4d into valkey-io:main Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eifrah-aws eifrah-aws eifrah-aws approved these changes

@ravisi21 ravisi21 ravisi21 approved these changes

Assignees

@janhavigupta007 janhavigupta007

Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhavigupta007 @eifrah-aws @ravisi21