Go:Fix benchmarking code and improve response side performance #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravisi21
reviewed
Sep 13, 2024
ravisi21
approved these changes
Sep 13, 2024
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
janhavigupta007
force-pushed
the
go/benchmarking_fix
branch
from
530c6d2
to
2fdcabc
Compare
acarbonetto
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Sep 18, 2024
…y-io#2288) Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
shohamazon
pushed a commit
to shohamazon/glide-for-redis
that referenced
this pull request
Sep 22, 2024
…y-io#2288) Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
ikolomi
pushed a commit
that referenced
this pull request
Sep 23, 2024
Signed-off-by: Janhavi Gupta <janhavigupta@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_existingwere off because initially it was not always fetching the existing keys. This PR fixes the same.Valuereceived from server toRust vecis avoided and the pointer is passed directly to Go.Benchmarking command: