Node: warp with try-catch the rust call and tests #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarovadya
changed the title
adarovadya
force-pushed
the
custom-command-node-2
branch
from
95e2bfd to
06941e9
Compare
avifenesh
reviewed
Aug 25, 2024
node/src/BaseClient.ts
Outdated
| resolve(resolveAns); | ||
| resolve(resolveAns); | ||
| } catch (err) { | ||
| console.log(err); |
There was a problem hiding this comment.
we dont console log in prod code
use the logger
added 4 commits
August 25, 2024 12:46
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
adarovadya
force-pushed
the
custom-command-node-2
branch
from
53a39af to
1c32029
Compare
avifenesh
approved these changes
Aug 26, 2024
prateek-kumar-improving
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Aug 26, 2024
* warp with try-catch the rust call and tests * add test --------- Signed-off-by: Adar Ovadia <adarov@amazon.com> Co-authored-by: Adar Ovadia <adarov@amazon.com>
| * @param valueResponse - Represents the encoded response of "value" to compare | ||
| * @returns Array of tuples, where first element is a test name/description, second - expected return value. | ||
| */ | ||
| export async function DumpAndRestureTest( |
There was a problem hiding this comment.
We already have this test
| @@ -32,6 +32,7 @@ import { | |||
| checkFunctionStatsResponse, | |||
| convertStringArrayToBuffer, | |||
| createLuaLibWithLongRunningFunction, | |||
| DumpAndRestureTest, | |||
There was a problem hiding this comment.
Resture? Who is that?
| @@ -242,6 +243,38 @@ describe("GlideClient", () => { | |||
| }, | |||
| ); | |||
|
|
|||
| it.each([ProtocolVersion.RESP2, ProtocolVersion.RESP3])( | |||
| `dump and restore transactions_%p`, | |||
There was a problem hiding this comment.
We alreayd have such test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description - #2119
Warping the valueFromSplitPointer rust function with try-cache and adding tests