Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: added DUMP and RESTORE commands #2126

Merged

Conversation

yipin-chen
Copy link
Collaborator

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen added the node Node.js wrapper label Aug 13, 2024
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen changed the title Node: added DUMP and RESTORE command Node: added DUMP and RESTORE commands Aug 13, 2024
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen
Copy link
Collaborator Author

As per discussion in PR review meeting, I have removed Transaction implementations and tests in this PR.

Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen force-pushed the node/integ_yipin_dump_restore_valkey-9 branch from 7b4f4de to 10541d0 Compare August 15, 2024 20:50
@yipin-chen yipin-chen marked this pull request as ready for review August 15, 2024 21:10
@yipin-chen yipin-chen requested a review from a team as a code owner August 15, 2024 21:10
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen force-pushed the node/integ_yipin_dump_restore_valkey-9 branch from 7a43c0b to a581cb2 Compare August 15, 2024 23:13
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
Signed-off-by: Yi-Pin Chen <yi-pin.chen@improving.com>
@yipin-chen yipin-chen merged commit 048812b into valkey-io:main Aug 17, 2024
17 checks passed
@yipin-chen yipin-chen deleted the node/integ_yipin_dump_restore_valkey-9 branch August 17, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants